chore: remove import-meta-resolve #13629
Open
+127
−85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I learned from @pi0 in #13513 that
import.meta.resolve
no longer takes a second argument, meaning it can't be used for resolving a peer dependency relative to the current working directory. As such, we won't be able to migrate to it once it's supported everywhere we care about.So unless we intend to keep
import-meta-resolve
around forever, we should just get rid of it now. I don't think we need to use a library for this (especially since we know which packages we're using this with, and so don't need to deal with any weird edge cases) — we can just implement the logic ourselves. This PR adds aresolve_peer
function which is duplicated betweenpackages/kit
andpackages/adapter-auto
, since a little duplication is better than faffing around with a more convoluted package structure.Closes #13528 (which has the 3.0 milestone, but this isn't a breaking change so we can do it immediately)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits